]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
regulator: bcm590xx: Use dev_err_probe for regulator register error
authorArtur Weber <aweber.kernel@gmail.com>
Thu, 15 May 2025 14:16:32 +0000 (16:16 +0200)
committerLee Jones <lee@kernel.org>
Thu, 22 May 2025 09:57:15 +0000 (10:57 +0100)
Instead of calling dev_err() and returning PTR_ERR(...) separately, use
a single "return dev_err_probe" statement.

Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
Reviewed-by: Stanislav Jakubek <stano.jakubek@gmail.com>
Reviewed-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20250515-bcm59054-v9-5-14ba0ea2ea5b@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/regulator/bcm590xx-regulator.c

index 9f0cda46b01506080ae5fa709104a8df4d174a8d..a17311fa30e4d48c0a4925778d7bed486ac7a982 100644 (file)
@@ -340,12 +340,10 @@ static int bcm590xx_probe(struct platform_device *pdev)
 
                rdev = devm_regulator_register(&pdev->dev, &pmu->desc[i],
                                               &config);
-               if (IS_ERR(rdev)) {
-                       dev_err(bcm590xx->dev,
-                               "failed to register %s regulator\n",
-                               pdev->name);
-                       return PTR_ERR(rdev);
-               }
+               if (IS_ERR(rdev))
+                       return dev_err_probe(bcm590xx->dev, PTR_ERR(rdev),
+                                            "failed to register %s regulator\n",
+                                            pdev->name);
        }
 
        return 0;