]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
usb: xhci: remove unused arguments from td_to_noop()
authorNiklas Neronin <niklas.neronin@linux.intel.com>
Wed, 6 Nov 2024 10:14:53 +0000 (12:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Nov 2024 12:26:15 +0000 (13:26 +0100)
Function td_to_noop() does not utilize arguments 'xhci' and 'ep_ring'.
These unused arguments are removed to clean up the code.

Signed-off-by: Niklas Neronin <niklas.neronin@linux.intel.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20241106101459.775897-28-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-ring.c

index 1b4c785c8dad75a14923568e51d1cd3ea2ab88f3..5fb3d771c429b71babe114a0536dc79ca2cf1b86 100644 (file)
@@ -740,8 +740,7 @@ static int xhci_move_dequeue_past_td(struct xhci_hcd *xhci,
  * (The last TRB actually points to the ring enqueue pointer, which is not part
  * of this TD.)  This is used to remove partially enqueued isoc TDs from a ring.
  */
-static void td_to_noop(struct xhci_hcd *xhci, struct xhci_ring *ep_ring,
-                      struct xhci_td *td, bool flip_cycle)
+static void td_to_noop(struct xhci_td *td, bool flip_cycle)
 {
        struct xhci_segment *seg        = td->start_seg;
        union xhci_trb *trb             = td->start_trb;
@@ -1020,16 +1019,16 @@ static int xhci_invalidate_cancelled_tds(struct xhci_virt_ep *ep)
                                                  "Found multiple active URBs %p and %p in stream %u?\n",
                                                  td->urb, cached_td->urb,
                                                  td->urb->stream_id);
-                                       td_to_noop(xhci, ring, cached_td, false);
+                                       td_to_noop(cached_td, false);
                                        cached_td->cancel_status = TD_CLEARED;
                                }
-                               td_to_noop(xhci, ring, td, false);
+                               td_to_noop(td, false);
                                td->cancel_status = TD_CLEARING_CACHE;
                                cached_td = td;
                                break;
                        }
                } else {
-                       td_to_noop(xhci, ring, td, false);
+                       td_to_noop(td, false);
                        td->cancel_status = TD_CLEARED;
                }
        }
@@ -1054,7 +1053,7 @@ static int xhci_invalidate_cancelled_tds(struct xhci_virt_ep *ep)
                                continue;
                        xhci_warn(xhci, "Failed to clear cancelled cached URB %p, mark clear anyway\n",
                                  td->urb);
-                       td_to_noop(xhci, ring, td, false);
+                       td_to_noop(td, false);
                        td->cancel_status = TD_CLEARED;
                }
        }
@@ -4192,7 +4191,7 @@ cleanup:
         */
        urb_priv->td[0].end_trb = ep_ring->enqueue;
        /* Every TRB except the first & last will have its cycle bit flipped. */
-       td_to_noop(xhci, ep_ring, &urb_priv->td[0], true);
+       td_to_noop(&urb_priv->td[0], true);
 
        /* Reset the ring enqueue back to the first TRB and its cycle bit. */
        ep_ring->enqueue = urb_priv->td[0].start_trb;