]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftests/ftrace: Replace echo -e with printf
authorJuerg Haefliger <juerg.haefliger@canonical.com>
Fri, 22 Feb 2019 20:53:50 +0000 (21:53 +0100)
committerShuah Khan <shuah@kernel.org>
Fri, 22 Feb 2019 22:25:18 +0000 (15:25 -0700)
echo -e is not POSIX. Depending on what /bin/sh is, we can get
incorrect output like:
$ -e -n [1] Basic trace file check
$ -e  [PASS]

Fix that by using printf instead.

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
Signed-off-by: Shuah Khan <shuah@kernel.org>
tools/testing/selftests/ftrace/ftracetest

index 75244db7033109adc43f27dbc2fc61d567421d76..2e5e66774dbbfc021a40a7c2cd2faea5729cce0d 100755 (executable)
@@ -173,8 +173,13 @@ strip_esc() {
 }
 
 prlog() { # messages
-  echo -e "$@"
-  [ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE
+  newline="\n"
+  if [ "$1" = "-n" ] ; then
+    newline=
+    shift
+  fi
+  printf "$*$newline"
+  [ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE
 }
 catlog() { #file
   cat $1