]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: chemical: bme680: Remove redundant gas configuration
authorVasileios Amoiridis <vassilisamir@gmail.com>
Sun, 9 Jun 2024 23:38:24 +0000 (01:38 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 3 Aug 2024 09:13:35 +0000 (10:13 +0100)
There is no need to explicitly configure the gas measurement registers
every time a gas measurement takes place. These are initial configurations
which are written in the beginning and they are not changed throughout
the lifetime of the driver.

If in the future, the device starts to support multiple configuration
profiles with variable heater duration and heater temperature, then they
could become members of the ->read_avail().

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
Link: https://patch.msgid.link/20240609233826.330516-14-vassilisamir@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/chemical/bme680_core.c

index b357871ef60189007d162875debcdab473a1d803..d08f32ecd1398192212c09559c856615156a9df0 100644 (file)
@@ -683,13 +683,6 @@ static int bme680_read_gas(struct bme680_data *data,
        u16 adc_gas_res, gas_regs_val;
        u8 gas_range;
 
-       /* Set heater settings */
-       ret = bme680_gas_config(data);
-       if (ret < 0) {
-               dev_err(dev, "failed to set gas config\n");
-               return ret;
-       }
-
        /* set forced mode to trigger measurement */
        ret = bme680_set_mode(data, true);
        if (ret < 0)