]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PM: sleep: Fix bit masking operation
authorColin Ian King <colin.i.king@gmail.com>
Wed, 19 Mar 2025 11:43:24 +0000 (11:43 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sat, 22 Mar 2025 13:55:08 +0000 (14:55 +0100)
The mask operation link->flags | DL_FLAG_PM_RUNTIME is always true which
is incorrect. The mask operation should be using the bit-wise &
operator. Fix this.

Fixes: bca84a7b93fd ("PM: sleep: Use DPM_FLAG_SMART_SUSPEND conditionally")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://patch.msgid.link/20250319114324.791829-1-colin.i.king@gmail.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/power/main.c

index ad50018b80479df8e3a6df9c8bafab880e1385c3..ac2a197c1234401b6bc921e1b56bf2aae3105f57 100644 (file)
@@ -1836,7 +1836,7 @@ static bool device_prepare_smart_suspend(struct device *dev)
        idx = device_links_read_lock();
 
        list_for_each_entry_rcu_locked(link, &dev->links.suppliers, c_node) {
-               if (!(link->flags | DL_FLAG_PM_RUNTIME))
+               if (!(link->flags & DL_FLAG_PM_RUNTIME))
                        continue;
 
                if (!dev_pm_smart_suspend(link->supplier) &&