BUG/MINOR: acme: fix possible NULL deref

Task was dereferenced when setting ctx but was checked after.
This patch move the setting of ctx after the check.

Should fix issue #2931

diff --git a/src/acme.c b/src/acme.c
index c3ee3cd331d2be6eb0a3dddc106f106e79b1876e..ce7f9684e342b878a933e040adf31c814753de45 100644 (file)
--- a/src/acme.c
+++ b/src/acme.c
@@ -493,11 +493,13 @@ REGISTER_CONFIG_SECTION("acme", cfg_parse_acme, cfg_postsection_acme);
 static void acme_httpclient_end(struct httpclient *hc)
 {
        struct task *task = hc->caller;
-       struct acme_ctx *ctx = task->context;
+       struct acme_ctx *ctx;
 
        if (!task)
                return;
 
+       ctx = task->context;
+
        if (ctx->http_state == ACME_HTTP_REQ)
                ctx->http_state = ACME_HTTP_RES;