]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli: Fix maybe-uninitialized warning
authorJennifer Sutton <jennifersutton@catalyst.net.nz>
Thu, 20 Feb 2025 00:51:24 +0000 (13:51 +1300)
committerDouglas Bagnall <dbagnall@samba.org>
Wed, 27 Aug 2025 03:41:36 +0000 (03:41 +0000)
../../libcli/wsp/wsp_aqs.c: In function ‘create_size_range_shortcut’:
../../libcli/wsp/wsp_aqs.c:872:37: error: ‘upper_size’ may be used uninitialized [-Werror=maybe-uninitialized]
  872 |                 right->value.number = upper_size;
      |                 ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
../../libcli/wsp/wsp_aqs.c:835:18: note: ‘upper_size’ was declared here
  835 |         uint32_t upper_size;
      |                  ^~~~~~~~~~
cc1: all warnings being treated as errors

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
libcli/wsp/wsp_aqs.c

index acf12293dafe82b799fb633cb92486b8d101fd7a..08723cf07e9d588f005013a808e7a55371cceefe 100644 (file)
@@ -831,8 +831,8 @@ t_value_holder *create_size_range_shortcut(TALLOC_CTX *ctx,
        };
        int i;
        t_value_holder *result = NULL;
-       uint32_t lower_size;
-       uint32_t upper_size;
+       uint32_t lower_size = 0;
+       uint32_t upper_size = 0;
        bool rangefound = false;
        t_value_holder *left = NULL;
        t_value_holder *right = NULL;