Fixup bad free.

git-svn-id: file:///svn/unbound/trunk@1635 be551aaa-1e26-0410-a405-d3ace91eadb9

diff --git a/doc/Changelog b/doc/Changelog
index 2614724aa919a969bce21ab6d1be2e2d0ee2ba3e..287a583f8d4cc48536807d22e83923b6c65aaf39 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,3 +1,7 @@
+3 June 2009: Wouter
+       - fixup bad free() when wrongly encoded DSA signature is seen.
+         Reported by Paul Wouters.
+
 2 June 2009: Wouter
        - --enable-sha2 option. The draft rsasha256 changed its algorithm
          numbers too often.  Therefore it is more prudent to disable the

diff --git a/validator/val_sigcrypt.c b/validator/val_sigcrypt.c
index 0d2ebf413df7ad476ffd669fbc9d96dbe24197aa..3f5e474337cd4e5784b1b78e65024849d0a39f6a 100644 (file)
--- a/validator/val_sigcrypt.c
+++ b/validator/val_sigcrypt.c
@@ -1193,7 +1193,7 @@ setup_dsa_sig(unsigned char** sig, unsigned int* len)
        *sig = NULL;
        newlen = i2d_DSA_SIG(dsasig, sig);
        if(newlen < 0) {
-               free(sig);
+               free(*sig);
                return 0;
        }
        *len = (unsigned int)newlen;