]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: macb: Check return value of dma_set_mask_and_coherent()
authorSergio Perez Gonzalez <sperezglz@gmail.com>
Mon, 26 May 2025 03:20:31 +0000 (21:20 -0600)
committerJakub Kicinski <kuba@kernel.org>
Wed, 28 May 2025 00:40:35 +0000 (17:40 -0700)
Issue flagged by coverity. Add a safety check for the return value
of dma_set_mask_and_coherent, go to a safe exit if it returns error.

Link: https://scan7.scan.coverity.com/#/project-view/53936/11354?selectedIssue=1643754
Signed-off-by: Sergio Perez Gonzalez <sperezglz@gmail.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Link: https://patch.msgid.link/20250526032034.84900-1-sperezglz@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cadence/macb_main.c

index e1e8bd2ec155b8938095c9d7a63a891cbf4438ed..d1f1ae5ea161ccfc5b039ef233f7db46471187af 100644 (file)
@@ -5283,7 +5283,11 @@ static int macb_probe(struct platform_device *pdev)
 
 #ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
        if (GEM_BFEXT(DAW64, gem_readl(bp, DCFG6))) {
-               dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(44));
+               err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(44));
+               if (err) {
+                       dev_err(&pdev->dev, "failed to set DMA mask\n");
+                       goto err_out_free_netdev;
+               }
                bp->hw_dma_cap |= HW_DMA_CAP_64B;
        }
 #endif