]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
hurd: Replace char foo[1024] with string_t
authorSamuel Thibault <samuel.thibault@ens-lyon.org>
Mon, 10 Feb 2025 19:06:35 +0000 (20:06 +0100)
committerSamuel Thibault <samuel.thibault@ens-lyon.org>
Mon, 10 Feb 2025 19:10:59 +0000 (20:10 +0100)
Like already done in various other places and advised by Roland in

https://lists.gnu.org/archive/html/bug-hurd/2012-04/msg00124.html

hurd/hurd/lookup.h
hurd/hurdlookup.c
hurd/lookup-at.c
hurd/lookup-retry.c
sysdeps/mach/hurd/bind.c
sysdeps/mach/hurd/dl-sysdep.c
sysdeps/mach/hurd/fexecve.c
sysdeps/mach/hurd/getlogin.c
sysdeps/mach/hurd/readlinkat.c
sysdeps/mach/hurd/ttyname.c
sysdeps/mach/hurd/ttyname_r.c

index f2ff0a1537fa3706526393a2e7dc6f0545ea387a..45f365f8d301a7fa4ae25086dfb25d70512beeec 100644 (file)
@@ -138,7 +138,7 @@ error_t __hurd_file_name_lookup_retry (error_t (*use_init_port)
                                          string_t retry_name,
                                          mach_port_t *result),
                                       enum retry_type doretry,
-                                      char retryname[1024],
+                                      string_t retryname,
                                       int flags, mode_t mode,
                                       file_t *result);
 error_t hurd_file_name_lookup_retry (error_t (*use_init_port)
@@ -152,7 +152,7 @@ error_t hurd_file_name_lookup_retry (error_t (*use_init_port)
                                        string_t retry_name,
                                        mach_port_t *result),
                                     enum retry_type doretry,
-                                    char retryname[1024],
+                                    string_t retryname,
                                     int flags, mode_t mode,
                                     file_t *result);
 
index 994d557ff76b78cec3ccb24fd1096688278f793c..f27bf3af6dba6d533f51de256536825cbe20069d 100644 (file)
@@ -51,7 +51,7 @@ __hurd_file_name_lookup (error_t (*use_init_port)
 {
   error_t err;
   enum retry_type doretry;
-  char retryname[1024];                /* XXX string_t LOSES! */
+  string_t retryname;
   int startport;
 
   error_t lookup_op (mach_port_t startdir)
index c2a1139dea1ac30e9af9acbb7f4ec31c082aa4ca..064b1ba4c6436d12591e916b25d9e10c51148c1f 100644 (file)
@@ -40,7 +40,7 @@ __file_name_lookup_at (int fd, int at_flags,
   if (empty != 0 && file_name[0] == '\0')
     {
       enum retry_type doretry;
-      char retryname[1024];    /* XXX string_t LOSES! */
+      string_t retryname;
 
       err = HURD_DPORT_USE (fd, __dir_lookup (port, "", flags, mode,
                                              &doretry, retryname,
index 3a9ad70f5d69433a3b856c3a21eee672c81fc099..6b94a10eae6b25ef5d796214d1c0e9c953890c1d 100644 (file)
@@ -53,7 +53,7 @@ __hurd_file_name_lookup_retry (error_t (*use_init_port)
                                  retry_type *do_retry, string_t retry_name,
                                  mach_port_t *result),
                               enum retry_type doretry,
-                              char retryname[1024],
+                              string_t retryname,
                               int flags, mode_t mode,
                               file_t *result)
 {
index bb408afcf64c2a0c42ad1070db92e1ce978ef818..cdcdd305ad1dd692fd30c2e082060d4a059e1532 100644 (file)
@@ -66,7 +66,7 @@ __bind  (int fd, __CONST_SOCKADDR_ARG addrarg, socklen_t len)
          if (! err)
            {
              enum retry_type doretry;
-             char retryname[1024];
+             string_t retryname;
              /* Get a port to the ifsock translator.  */
              err = __dir_lookup (node, "", 0, 0, &doretry, retryname, &ifsock);
              if (! err && (doretry != FS_RETRY_NORMAL || retryname[0] != '\0'))
index 0ddb220a4e8cbadfe24c68752091b93bdf339573..173499c4c1fe8d3d301db55e33bc8b55468cb36c 100644 (file)
@@ -267,7 +267,7 @@ open_file (const char *file_name, int flags,
           mach_port_t *port, struct stat64 *stat)
 {
   enum retry_type doretry;
-  char retryname[1024];                /* XXX string_t LOSES! */
+  string_t retryname;
   file_t startdir;
   error_t err;
 
index 906cd86be4908a986f7b2b05520681cabdbb4d6b..cd3bd2b2692ac69f3ceab0f1e3b7eefc72845838 100644 (file)
@@ -28,7 +28,7 @@ fexecve (int fd, char *const argv[], char *const envp[])
   file_t file;
   error_t err;
   enum retry_type doretry;
-  char retryname[1024];
+  string_t retryname;
 
   err = HURD_DPORT_USE (fd,
       __dir_lookup (port, "", O_EXEC, 0, &doretry, retryname, &file));
index b3427b0fc0efe11f947a2a2e0ae591838bbcb2c7..d73c03437320ab152d5edc35ceb6084bccc9b99d 100644 (file)
@@ -25,7 +25,7 @@
 char *
 getlogin (void)
 {
-  static char login[1024];     /* XXX */
+  static string_t login;
   error_t err;
 
   if (err = __USEPORT (PROC, __proc_getlogin (port, login)))
index e56764de54593e0ecab7e3db2831b3779d259352..dbbc528ffb66ffa5e8dd40397c6970319b7c2cf1 100644 (file)
@@ -32,7 +32,7 @@ __readlinkat (int fd, const char *file_name, char *buf, size_t len)
   file_t file_stat;
   struct stat64 st;
   enum retry_type doretry;
-  char retryname[1024];
+  string_t retryname;
   file_t file;
   char *rbuf = buf;
   mach_msg_type_number_t nread = len;
index 62c3bf76153be60a500f831d7938628654d8fb6c..1353fe8e1d06fb5d44d0adc317dc21e4346f71a6 100644 (file)
@@ -27,7 +27,7 @@ char *
 ttyname (int fd)
 {
   error_t err;
-  static char nodename[1024];  /* XXX */
+  static string_t nodename;
 
   if (err = HURD_DPORT_USE (fd, __term_get_nodename (port, nodename)))
     {
index f0e3f65dbee872badedf842f78f134651e86e556..836ec6aca2ee3bce572cbd6db2586fc8b5c4a40c 100644 (file)
@@ -28,7 +28,7 @@ int
 __ttyname_r (int fd, char *buf, size_t buflen)
 {
   error_t err;
-  char nodename[1024]; /* XXX */
+  string_t nodename;
   size_t len;
 
   if (err = HURD_DPORT_USE (fd, __term_get_nodename (port, nodename)))