]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
backlight: lp8788: Fully initialize backlight_properties during probe
authorDaniel Thompson <daniel.thompson@linaro.org>
Tue, 20 Feb 2024 15:35:26 +0000 (15:35 +0000)
committerLee Jones <lee@kernel.org>
Thu, 7 Mar 2024 09:03:29 +0000 (09:03 +0000)
props is stack allocated and the fields that are not explcitly set
by the probe function need to be zeroed or we'll get undefined behaviour
(especially so power/blank states)!

Fixes: c5a51053cf3b ("backlight: add new lp8788 backlight driver")
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20240220153532.76613-4-daniel.thompson@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/video/backlight/lp8788_bl.c

index d1a14b0db265b7ce303662b789c2f13c4f21837a..31f97230ee506a55eb1632ef34d5a17e2fc9075a 100644 (file)
@@ -191,6 +191,7 @@ static int lp8788_backlight_register(struct lp8788_bl *bl)
        int init_brt;
        char *name;
 
+       memset(&props, 0, sizeof(struct backlight_properties));
        props.type = BACKLIGHT_PLATFORM;
        props.max_brightness = MAX_BRIGHTNESS;