]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: fnic: Return appropriate error code from failure of scsi drv init
authorKaran Tilak Kumar <kartilak@cisco.com>
Fri, 10 Jan 2025 09:18:42 +0000 (01:18 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 10 Jan 2025 23:23:04 +0000 (18:23 -0500)
Return appropriate error code from fnic_probe caused by failure of
fnic_scsi_drv_init. Fix bug report.

Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com>
Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>
Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com>
Reviewed-by: Arun Easi <aeasi@cisco.com>
Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
Link: https://lore.kernel.org/r/20250110091842.17711-1-kartilak@cisco.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/fnic/fnic_main.c

index 2d51adf18501a7e6c1b0eeffd9d9fce608aefd66..9ed42d5819d5e3e41c23d4c9202bb7306d3bb529 100644 (file)
@@ -1039,7 +1039,8 @@ static int fnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
        fnic_fdls_init(fnic, (fnic->config.flags & VFCF_FIP_CAPABLE));
 
-       if (fnic_scsi_drv_init(fnic))
+       err = fnic_scsi_drv_init(fnic);
+       if (err)
                goto err_out_scsi_drv_init;
 
        err = fnic_stats_debugfs_init(fnic);