slab: turn freelist_aba_t to a struct and fully define counters there

In struct slab we currently have freelist and counters pair, where
counters itself is a union of unsigned long with a sub-struct of
several smaller fields. Then for the usage with double cmpxchg we have
freelist_aba_t that duplicates the definition of the freelist+counters
with implicitly the same layout as the full definition in struct slab.

Thanks to -fms-extension we can now move the full counters definition to
freelist_aba_t (while changing it to struct freelist_counters as a
typedef is unnecessary and discouraged) and replace the relevant part in
struct slab to an unnamed reference to it.

The immediate benefit is the removal of duplication and no longer
relying on the same layout implicitly. It also allows further cleanups
thanks to having the full definition of counters in struct
freelist_counters.

Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>

diff --git a/mm/slab.h b/mm/slab.h
index 078daecc7cf50a0c01aca3c3c9c866dc8b1a756d..42627b87d50ca4845608935a75fd7eb4b27d8892 100644 (file)
--- a/mm/slab.h
+++ b/mm/slab.h
@@ -40,13 +40,29 @@ typedef u64 freelist_full_t;
  * Freelist pointer and counter to cmpxchg together, avoids the typical ABA
  * problems with cmpxchg of just a pointer.
  */
-typedef union {
-       struct {
-               void *freelist;
-               unsigned long counter;
+struct freelist_counters {
+       union {
+               struct {
+                       void *freelist;
+                       union {
+                               unsigned long counters;
+                               struct {
+                                       unsigned inuse:16;
+                                       unsigned objects:15;
+                                       /*
+                                        * If slab debugging is enabled then the
+                                        * frozen bit can be reused to indicate
+                                        * that the slab was corrupted
+                                        */
+                                       unsigned frozen:1;
+                               };
+                       };
+               };
+#ifdef system_has_freelist_aba
+               freelist_full_t freelist_counters;
+#endif
        };
-       freelist_full_t full;
-} freelist_aba_t;
+};
 
 /* Reuses the bits in struct page */
 struct slab {
@@ -69,27 +85,7 @@ struct slab {
 #endif
                        };
                        /* Double-word boundary */
-                       union {
-                               struct {
-                                       void *freelist;         /* first free object */
-                                       union {
-                                               unsigned long counters;
-                                               struct {
-                                                       unsigned inuse:16;
-                                                       unsigned objects:15;
-                                                       /*
-                                                        * If slab debugging is enabled then the
-                                                        * frozen bit can be reused to indicate
-                                                        * that the slab was corrupted
-                                                        */
-                                                       unsigned frozen:1;
-                                               };
-                                       };
-                               };
-#ifdef system_has_freelist_aba
-                               freelist_aba_t freelist_counter;
-#endif
-                       };
+                       struct freelist_counters;
                };
                struct rcu_head rcu_head;
        };
@@ -114,7 +110,7 @@ SLAB_MATCH(_unused_slab_obj_exts, obj_exts);
 #undef SLAB_MATCH
 static_assert(sizeof(struct slab) <= sizeof(struct page));
 #if defined(system_has_freelist_aba)
-static_assert(IS_ALIGNED(offsetof(struct slab, freelist), sizeof(freelist_aba_t)));
+static_assert(IS_ALIGNED(offsetof(struct slab, freelist), sizeof(struct freelist_counters)));
 #endif
 
 /**

diff --git a/mm/slub.c b/mm/slub.c
index 5f6408c9e0fdaec618fe7de0a8fa991f47a72ca6..8330e4f8b3b24ce6a0163daf662da75219b5f8af 100644 (file)
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -764,10 +764,12 @@ __update_freelist_fast(struct slab *slab,
                      void *freelist_new, unsigned long counters_new)
 {
 #ifdef system_has_freelist_aba
-       freelist_aba_t old = { .freelist = freelist_old, .counter = counters_old };
-       freelist_aba_t new = { .freelist = freelist_new, .counter = counters_new };
+       struct freelist_counters old = { .freelist = freelist_old, .counters = counters_old };
+       struct freelist_counters new = { .freelist = freelist_new, .counters = counters_new };
 
-       return try_cmpxchg_freelist(&slab->freelist_counter.full, &old.full, new.full);
+       return try_cmpxchg_freelist(&slab->freelist_counters,
+                                   &old.freelist_counters,
+                                   new.freelist_counters);
 #else
        return false;
 #endif