xfrm: Remove unnecessary NULL check in xfrm_lookup_with_ifid()

This NULL check is unnecessary and can be removed.  It confuses
Smatch static analysis tool because it makes Smatch think that
xfrm_lookup_with_ifid() can return a mix of NULL pointers and errors so
it creates a lot of false positives.  Remove it.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index 6551e588fe526fb2b4ea93ff0487d4d13b772c81..30970d40a454f4644a41cc8d5b7248133ea2ff10 100644 (file)
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -3294,7 +3294,7 @@ no_transform:
 
 ok:
        xfrm_pols_put(pols, drop_pols);
-       if (dst && dst->xfrm &&
+       if (dst->xfrm &&
            (dst->xfrm->props.mode == XFRM_MODE_TUNNEL ||
             dst->xfrm->props.mode == XFRM_MODE_IPTFS))
                dst->flags |= DST_XFRM_TUNNEL;