]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
hwmon: (adt7475) Fix default duty on fan is disabled
authorWayne Tung <chineweff@gmail.com>
Mon, 1 Jul 2024 07:32:52 +0000 (15:32 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 1 Jul 2024 22:45:57 +0000 (15:45 -0700)
According to the comments on fan is disabled, we change to manual mode
and set the duty cycle to 0.
For setting the duty cycle part, the register is wrong. Fix it.

Fixes: 1c301fc5394f ("hwmon: Add a driver for the ADT7475 hardware monitoring chip")
Signed-off-by: Wayne Tung <chineweff@gmail.com>
Link: https://lore.kernel.org/r/20240701073252.317397-1-chineweff@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/adt7475.c

index 5f78e66330187dfb01cd36fe1fa107fd6b434b2f..bc186c61a2c0a575118f1c97bf28f39881da5c31 100644 (file)
@@ -1896,7 +1896,7 @@ static void adt7475_read_pwm(struct i2c_client *client, int index)
                data->pwm[CONTROL][index] &= ~0xE0;
                data->pwm[CONTROL][index] |= (7 << 5);
 
-               i2c_smbus_write_byte_data(client, PWM_CONFIG_REG(index),
+               i2c_smbus_write_byte_data(client, PWM_REG(index),
                                          data->pwm[INPUT][index]);
 
                i2c_smbus_write_byte_data(client, PWM_CONFIG_REG(index),