]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
unix-socket: address scan-build warning
authorVictor Julien <vjulien@oisf.net>
Wed, 10 Sep 2025 14:06:11 +0000 (16:06 +0200)
committerVictor Julien <victor@inliniac.net>
Sat, 13 Sep 2025 06:40:11 +0000 (08:40 +0200)
  CC       unix-manager.o
unix-manager.c:258:13: warning: Use of memory after it is freed [unix.Malloc]
  258 |         if (item->fd == fd) {
      |             ^~~~~~~~
1 warning generated.

src/unix-manager.c

index f10d56930972760c29843b950b86e05f21b28059..3d8d120bd3b2387d21dd3244361e3be75238d742 100644 (file)
@@ -252,9 +252,10 @@ static void UnixClientFree(UnixClient *c)
 static void UnixCommandClose(UnixCommand  *this, int fd)
 {
     UnixClient *item;
+    UnixClient *safe = NULL;
     int found = 0;
 
-    TAILQ_FOREACH(item, &this->clients, next) {
+    TAILQ_FOREACH_SAFE (item, &this->clients, next, safe) {
         if (item->fd == fd) {
             found = 1;
             break;