]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftests/pcie_bwctrl: Fix test progs list
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 17 Apr 2025 12:45:29 +0000 (15:45 +0300)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 18 Apr 2025 13:23:22 +0000 (08:23 -0500)
Commit df6f8c4d72ae ("selftests/pcie_bwctrl: Add 'set_pcie_speed.sh' to
TEST_PROGS") added set_pcie_speed.sh into TEST_PROGS but that script is a
helper that is only being called by set_pcie_cooling_state.sh, not a test
case itself. When set_pcie_speed.sh is in TEST_PROGS, selftest harness will
execute also it leading to bwctrl selftest errors:

  # selftests: pcie_bwctrl: set_pcie_speed.sh
  # cat: /cur_state: No such file or directory
  not ok 2 selftests: pcie_bwctrl: set_pcie_speed.sh # exit=1

Place set_pcie_speed.sh into TEST_FILES instead to have it included into
installed test files but not execute it from the test harness.

Fixes: df6f8c4d72ae ("selftests/pcie_bwctrl: Add 'set_pcie_speed.sh' to TEST_PROGS")
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20250417124529.11391-1-ilpo.jarvinen@linux.intel.com
tools/testing/selftests/pcie_bwctrl/Makefile

index 48ec048f47afda6c92b27830610ede3836ffbcf5..277f92f9d7537a3b11f311017fd43d12c5222298 100644 (file)
@@ -1,2 +1,3 @@
-TEST_PROGS = set_pcie_cooling_state.sh set_pcie_speed.sh
+TEST_PROGS = set_pcie_cooling_state.sh
+TEST_FILES = set_pcie_speed.sh
 include ../lib.mk