]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
tls: snmp: do not use SNMP_MIB_SENTINEL anymore
authorEric Dumazet <edumazet@google.com>
Fri, 5 Sep 2025 16:58:11 +0000 (16:58 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 9 Sep 2025 01:06:21 +0000 (18:06 -0700)
Use ARRAY_SIZE(), so that we know the limit at compile time.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: John Fastabend <john.fastabend@gmail.com>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://patch.msgid.link/20250905165813.1470708-8-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/tls/tls_proc.c

index 367666aa07b8810e6a9b19c0697610900fa6a7c9..4012c4372d4c091dfd7eab74418fb50a4eab2654 100644 (file)
@@ -27,17 +27,19 @@ static const struct snmp_mib tls_mib_list[] = {
        SNMP_MIB_ITEM("TlsTxRekeyOk", LINUX_MIB_TLSTXREKEYOK),
        SNMP_MIB_ITEM("TlsTxRekeyError", LINUX_MIB_TLSTXREKEYERROR),
        SNMP_MIB_ITEM("TlsRxRekeyReceived", LINUX_MIB_TLSRXREKEYRECEIVED),
-       SNMP_MIB_SENTINEL
 };
 
 static int tls_statistics_seq_show(struct seq_file *seq, void *v)
 {
-       unsigned long buf[LINUX_MIB_TLSMAX] = {};
+       unsigned long buf[ARRAY_SIZE(tls_mib_list)];
+       const int cnt = ARRAY_SIZE(tls_mib_list);
        struct net *net = seq->private;
        int i;
 
-       snmp_get_cpu_field_batch(buf, tls_mib_list, net->mib.tls_statistics);
-       for (i = 0; tls_mib_list[i].name; i++)
+       memset(buf, 0, sizeof(buf));
+       snmp_get_cpu_field_batch_cnt(buf, tls_mib_list, cnt,
+                                    net->mib.tls_statistics);
+       for (i = 0; i < cnt; i++)
                seq_printf(seq, "%-32s\t%lu\n", tls_mib_list[i].name, buf[i]);
 
        return 0;