]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ALSA: seq: seq_oss_event: fix inconsistent indenting warning in note_on_event()
authorCharles Han <hanchunchao@inspur.com>
Fri, 28 Feb 2025 03:34:27 +0000 (11:34 +0800)
committerTakashi Iwai <tiwai@suse.de>
Fri, 28 Feb 2025 09:35:20 +0000 (10:35 +0100)
Fix below inconsistent indenting smatch warning.
smatch warnings:
sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn: inconsistent indenting

Signed-off-by: Charles Han <hanchunchao@inspur.com>
Link: https://patch.msgid.link/20250228033427.7056-1-hanchunchao@inspur.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/oss/seq_oss_event.c

index 7b7c925dd3aa288896d72aac70dc7ea82249fe58..76fb81077eef798a5151c399f16ec5081ef766fd 100644 (file)
@@ -290,16 +290,14 @@ note_on_event(struct seq_oss_devinfo *dp, int dev, int ch, int note, int vel, st
                if (note == 255 && info->ch[ch].note >= 0) {
                        /* volume control */
                        int type;
-                       //if (! vel)
-                               /* set volume to zero -- note off */
-                       //      type = SNDRV_SEQ_EVENT_NOTEOFF;
-                       //else
-                               if (info->ch[ch].vel)
+
+                       if (info->ch[ch].vel)
                                /* sample already started -- volume change */
                                type = SNDRV_SEQ_EVENT_KEYPRESS;
                        else
                                /* sample not started -- start now */
                                type = SNDRV_SEQ_EVENT_NOTEON;
+
                        info->ch[ch].vel = vel;
                        return set_note_event(dp, dev, type, ch, info->ch[ch].note, vel, ev);
                } else if (note >= 128)