]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
fix 1.4 test suite
authorMike Bayer <mike_mp@zzzcomputing.com>
Thu, 19 Oct 2023 13:59:34 +0000 (09:59 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Thu, 19 Oct 2023 13:59:34 +0000 (09:59 -0400)
add some recent fixes so we can get new 1.4 fixes merged

Change-Id: I692c8adb6b22f10629b9d797c1a64334d43f13b3

test/dialect/postgresql/test_reflection.py
test/orm/inheritance/test_basic.py

index f33b3bde45417af9c36e18e51d50d38a36a59fd4..807ea128198790833c8c00b663b477373540da87 100644 (file)
@@ -303,13 +303,18 @@ class MaterializedViewReflectionTest(
 
     def test_get_view_definition(self, connection):
         insp = inspect(connection)
+
+        def normalize(definition):
+            # pg16 returns "SELECT" without qualifying tablename.
+            # older pgs include it
+            definition = re.sub(
+                r"testtable\.(\w+)", lambda m: m.group(1), definition
+            )
+            return re.sub(r"[\n\t ]+", " ", definition.strip())
+
         eq_(
-            re.sub(
-                r"[\n\t ]+",
-                " ",
-                insp.get_view_definition("test_mview").strip(),
-            ),
-            "SELECT testtable.id, testtable.data FROM testtable;",
+            normalize(insp.get_view_definition("test_mview")),
+            "SELECT id, data FROM testtable;",
         )
 
 
index 9daafb7cefb371649614fe63620d4b0657bf8e56..e2348bb8a49995a61ba7897cb96ef451ab14cbb2 100644 (file)
@@ -171,6 +171,7 @@ class ColExpressionsTest(fixtures.DeclarativeMappedTest):
         rows = (
             s.query(B.id.expressions[0], B.id.expressions[1], func.sum(B.data))
             .group_by(*B.id.expressions)
+            .order_by(B.id.expressions[0])
             .all()
         )
         eq_(rows, [(1, 1, 5), (2, 2, 7)])