mmc: sdhci-pxav2: Remove unnecessary null pointer check

There is no need to check for a null mrq->cmd in pxav1_request_done.
mmc_request_done already assumes it's not null, and it's always called
in this path by every SDHCI driver. This was caught by Smatch.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/9ddaef2a-05bb-4fe7-98c5-da40a0813027@stanley.mountain/
Signed-off-by: Doug Brown <doug@schmorgal.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20240714155510.48880-1-doug@schmorgal.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

diff --git a/drivers/mmc/host/sdhci-pxav2.c b/drivers/mmc/host/sdhci-pxav2.c
index b75cbea88b4020885d1ad2de31e14faa7fa2414d..7b957f6d55884a59440fa5cae6dbe80febde60a2 100644 (file)
--- a/drivers/mmc/host/sdhci-pxav2.c
+++ b/drivers/mmc/host/sdhci-pxav2.c
@@ -126,7 +126,7 @@ static void pxav1_request_done(struct sdhci_host *host, struct mmc_request *mrq)
        struct sdhci_pxav2_host *pxav2_host;
 
        /* If this is an SDIO command, perform errata workaround for silicon bug */
-       if (mrq->cmd && !mrq->cmd->error &&
+       if (!mrq->cmd->error &&
            (mrq->cmd->opcode == SD_IO_RW_DIRECT ||
             mrq->cmd->opcode == SD_IO_RW_EXTENDED)) {
                /* Reset data port */