hamradio: baycom: replace strcpy() with strscpy()

The strcpy() function has been deprecated and replaced with strscpy().
There is an effort to make this change treewide:
https://github.com/KSPP/linux/issues/88.

Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/3qo3fbrak7undfgocsi2s74v4uyjbylpdqhie4dohfoh4welfn@joq7up65ug6v
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/hamradio/baycom_par.c b/drivers/net/hamradio/baycom_par.c
index 00ebc25d0b22a706ab9582ca69fdfb49c4cdc65d..f03797103c6a252ca279d562afbe7f8ec8fb902e 100644 (file)
--- a/drivers/net/hamradio/baycom_par.c
+++ b/drivers/net/hamradio/baycom_par.c
@@ -427,7 +427,7 @@ static int baycom_ioctl(struct net_device *dev, void __user *data,
                break;
 
        case HDLCDRVCTL_GETMODE:
-               strcpy(hi->data.modename, bc->options ? "par96" : "picpar");
+               strscpy(hi->data.modename, bc->options ? "par96" : "picpar");
                if (copy_to_user(data, hi, sizeof(struct hdlcdrv_ioctl)))
                        return -EFAULT;
                return 0;
@@ -439,7 +439,7 @@ static int baycom_ioctl(struct net_device *dev, void __user *data,
                return baycom_setmode(bc, hi->data.modename);
 
        case HDLCDRVCTL_MODELIST:
-               strcpy(hi->data.modename, "par96,picpar");
+               strscpy(hi->data.modename, "par96,picpar");
                if (copy_to_user(data, hi, sizeof(struct hdlcdrv_ioctl)))
                        return -EFAULT;
                return 0;

diff --git a/drivers/net/hamradio/baycom_ser_fdx.c b/drivers/net/hamradio/baycom_ser_fdx.c
index 799f8ece7824f2e46b0701d9b34b9287d4d1f6d8..ee5bd3c120400a5bfed5f243d9216f275e2910d4 100644 (file)
--- a/drivers/net/hamradio/baycom_ser_fdx.c
+++ b/drivers/net/hamradio/baycom_ser_fdx.c
@@ -531,7 +531,7 @@ static int baycom_ioctl(struct net_device *dev, void __user *data,
                return baycom_setmode(bc, hi->data.modename);
 
        case HDLCDRVCTL_MODELIST:
-               strcpy(hi->data.modename, "ser12,ser3,ser24");
+               strscpy(hi->data.modename, "ser12,ser3,ser24");
                if (copy_to_user(data, hi, sizeof(struct hdlcdrv_ioctl)))
                        return -EFAULT;
                return 0;

diff --git a/drivers/net/hamradio/baycom_ser_hdx.c b/drivers/net/hamradio/baycom_ser_hdx.c
index 5d1ab4840753febefe87dbcea9ca7b18fedca05e..05bdad2147999cecc30087231f0dc1d0372709c2 100644 (file)
--- a/drivers/net/hamradio/baycom_ser_hdx.c
+++ b/drivers/net/hamradio/baycom_ser_hdx.c
@@ -570,7 +570,7 @@ static int baycom_ioctl(struct net_device *dev, void __user *data,
                break;
 
        case HDLCDRVCTL_GETMODE:
-               strcpy(hi->data.modename, "ser12");
+               strscpy(hi->data.modename, "ser12");
                if (bc->opt_dcd <= 0)
                        strcat(hi->data.modename, (!bc->opt_dcd) ? "*" : (bc->opt_dcd == -2) ? "@" : "+");
                if (copy_to_user(data, hi, sizeof(struct hdlcdrv_ioctl)))
@@ -584,7 +584,7 @@ static int baycom_ioctl(struct net_device *dev, void __user *data,
                return baycom_setmode(bc, hi->data.modename);
 
        case HDLCDRVCTL_MODELIST:
-               strcpy(hi->data.modename, "ser12");
+               strscpy(hi->data.modename, "ser12");
                if (copy_to_user(data, hi, sizeof(struct hdlcdrv_ioctl)))
                        return -EFAULT;
                return 0;