repo: Make conversion to package list static

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/src/pakfire/repo.c b/src/pakfire/repo.c
index a2c337a67abd60f1a41e1333d39496654a490506..e4ecfd413e2ad1a5305c4fe777b7b529a3c06ffd 100644 (file)
--- a/src/pakfire/repo.c
+++ b/src/pakfire/repo.c
@@ -2104,7 +2104,7 @@ ERROR:
        return r;
 }
 
-int pakfire_repo_to_packagelist(struct pakfire_repo* repo,
+static int pakfire_repo_to_packagelist(struct pakfire_repo* repo,
                struct pakfire_packagelist* list) {
        struct pakfire_package* pkg = NULL;
        Solvable* s = NULL;
@@ -2118,13 +2118,13 @@ int pakfire_repo_to_packagelist(struct pakfire_repo* repo,
 
                // Create a new package
                r = pakfire_package_create_from_solvable(&pkg, repo->pakfire, id);
-               if (r)
+               if (r < 0)
                        return r;
 
                // Append the package to the list
                r = pakfire_packagelist_push(list, pkg);
                pakfire_package_unref(pkg);
-               if (r)
+               if (r < 0)
                        return r;
        }
 

diff --git a/src/pakfire/repo.h b/src/pakfire/repo.h
index 21947b4c853a36099a5d0715d44a74f6cf2e8d34..cac73af04a0bb358f7ecdd00721e16c6d008defb 100644 (file)
--- a/src/pakfire/repo.h
+++ b/src/pakfire/repo.h
@@ -135,9 +135,6 @@ Repodata* pakfire_repo_get_repodata(struct pakfire_repo* repo);
 
 struct pakfire_mirrorlist* pakfire_repo_get_mirrorlist(struct pakfire_repo* repo);
 
-int pakfire_repo_to_packagelist(struct pakfire_repo* repo,
-       struct pakfire_packagelist* list);
-
 int pakfire_repo_walk_packages(struct pakfire_repo* self,
        int (*callback)(struct pakfire_ctx* ctx, struct pakfire_package* pkg, void* data), void* data, int flags);