]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpufreq/amd-pstate: Drop cached epp_policy variable
authorMario Limonciello <mario.limonciello@amd.com>
Mon, 9 Dec 2024 18:52:38 +0000 (12:52 -0600)
committerMario Limonciello <mario.limonciello@amd.com>
Wed, 11 Dec 2024 16:44:52 +0000 (10:44 -0600)
epp_policy is not used by any of the current code and there
is no need to cache it.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Link: https://lore.kernel.org/r/20241209185248.16301-6-mario.limonciello@amd.com
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
drivers/cpufreq/amd-pstate.c
drivers/cpufreq/amd-pstate.h

index bcb9367aa9ca0aef481dbca0ebd167be8301f79f..0e77584dfadecde0cfb842792efb779017d1ff26 100644 (file)
@@ -1478,7 +1478,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
                return -ENOMEM;
 
        cpudata->cpu = policy->cpu;
-       cpudata->epp_policy = 0;
 
        ret = amd_pstate_init_perf(cpudata);
        if (ret)
@@ -1585,8 +1584,6 @@ static int amd_pstate_epp_update_limit(struct cpufreq_policy *policy)
        value &= ~AMD_CPPC_DES_PERF(~0L);
        value |= AMD_CPPC_DES_PERF(0);
 
-       cpudata->epp_policy = cpudata->policy;
-
        /* Get BIOS pre-defined epp value */
        epp = amd_pstate_get_epp(cpudata, value);
        if (epp < 0) {
index cd573bc6b6db83a62d7a5073fab8152b9d9e7b88..7765c82f975c641e33a2ba919723d3e217c842bb 100644 (file)
@@ -57,7 +57,6 @@ struct amd_aperf_mperf {
  * @hw_prefcore: check whether HW supports preferred core featue.
  *               Only when hw_prefcore and early prefcore param are true,
  *               AMD P-State driver supports preferred core featue.
- * @epp_policy: Last saved policy used to set energy-performance preference
  * @epp_cached: Cached CPPC energy-performance preference value
  * @policy: Cpufreq policy value
  * @cppc_cap1_cached Cached MSR_AMD_CPPC_CAP1 register value
@@ -94,7 +93,6 @@ struct amd_cpudata {
        bool    hw_prefcore;
 
        /* EPP feature related attributes*/
-       s16     epp_policy;
        s16     epp_cached;
        u32     policy;
        u64     cppc_cap1_cached;