]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
gdbstub: assert earlier in handle_read_all_regs
authorAlex Bennée <alex.bennee@linaro.org>
Tue, 3 Jun 2025 11:02:02 +0000 (12:02 +0100)
committerAlex Bennée <alex.bennee@linaro.org>
Sat, 7 Jun 2025 15:40:44 +0000 (16:40 +0100)
When things go wrong we want to assert on the register that failed to
be able to figure out what went wrong.

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-ID: <20250603110204.838117-16-alex.bennee@linaro.org>

gdbstub/gdbstub.c

index 565f6b33a90a8ed77f50b4aa6bcabbdb5441bb01..6023c80d25f072d78f4a9fe882719492af647aa2 100644 (file)
@@ -1343,8 +1343,8 @@ static void handle_read_all_regs(GArray *params, void *user_ctx)
         len += gdb_read_register(gdbserver_state.g_cpu,
                                  gdbserver_state.mem_buf,
                                  reg_id);
+        g_assert(len == gdbserver_state.mem_buf->len);
     }
-    g_assert(len == gdbserver_state.mem_buf->len);
 
     gdb_memtohex(gdbserver_state.str_buf, gdbserver_state.mem_buf->data, len);
     gdb_put_strbuf();