]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_process.c: check migrateURI when setting VIR_QEMU_PROCESS_START_NEW
authorDaniel Henrique Barboza <danielhb413@gmail.com>
Wed, 18 Nov 2020 17:56:24 +0000 (14:56 -0300)
committerDaniel Henrique Barboza <danielhb413@gmail.com>
Thu, 3 Dec 2020 20:16:33 +0000 (17:16 -0300)
qemuProcessCreatePretendCmdPrepare() is setting the
VIR_QEMU_PROCESS_START_NEW regardless of whether this is
a migration case or not. This behavior differs from what we're
doing in qemuProcessStart(), where the flag is set only
if !migrate && !snapshot.

Fix it by making the flag setting consistent with what we're
doing in qemuProcessStart().

Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/qemu/qemu_process.c

index 01afe66ec961fe09ac11db993e6fefa5797fc306..27a22c950df23dcb465fe593cc43d26c669b10ed 100644 (file)
@@ -7436,7 +7436,10 @@ qemuProcessCreatePretendCmdPrepare(virQEMUDriverPtr driver,
                   VIR_QEMU_PROCESS_START_AUTODESTROY, -1);
 
     flags |= VIR_QEMU_PROCESS_START_PRETEND;
-    flags |= VIR_QEMU_PROCESS_START_NEW;
+
+    if (!migrateURI)
+        flags |= VIR_QEMU_PROCESS_START_NEW;
+
     if (standalone)
         flags |= VIR_QEMU_PROCESS_START_STANDALONE;