]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: regmap: fix memory leak of gpio_regmap structure
authorIoana Ciornei <ioana.ciornei@nxp.com>
Mon, 22 Sep 2025 14:24:21 +0000 (17:24 +0300)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 22 Sep 2025 14:35:21 +0000 (16:35 +0200)
The gpio_regmap structure is leaked on the error path. Fix this by
jumping to the appropriate kfree instead of returning directly.

Fixes: db305161880a ("gpio: regmap: Allow ngpio to be read from the property")
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Suggested-by: Michael Walle <mwalle@kernel.org>
Reviewed-by: Michael Walle <mwalle@kernel.org>
Link: https://lore.kernel.org/r/20250922142427.3310221-7-ioana.ciornei@nxp.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-regmap.c

index e8a32dfebdcb31890e691f6739e8a76a02662202..3f8b72311f8e8413a3c224c29abe17fd1f9e79e0 100644 (file)
@@ -274,7 +274,7 @@ struct gpio_regmap *gpio_regmap_register(const struct gpio_regmap_config *config
        if (!chip->ngpio) {
                ret = gpiochip_get_ngpios(chip, chip->parent);
                if (ret)
-                       return ERR_PTR(ret);
+                       goto err_free_gpio;
        }
 
        /* if not set, assume there is only one register */