]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Get default hugepage size only if needed
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 27 May 2019 09:07:12 +0000 (11:07 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 27 May 2019 12:53:53 +0000 (14:53 +0200)
Fixes: 6864d8f740e2502dc7625bdf18ffde4465b14f69
Hugepages don't work in session mode but when building memory
part of command line we query for the default size anyway. This
breaks creating domains under session daemon. Query the page size
only if it's clear we need hugepages.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
(cherry picked from commit c46bdad5768da39bbccaa66c5c63f7303e56ad49)
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_command.c

index 50b42052677bc3ffc625ce7e328025251da1b983..6f45174726927f7d4a6aa6ac812cf9b978292c51 100644 (file)
@@ -3573,7 +3573,7 @@ qemuBuildMemoryBackendProps(virJSONValuePtr *backendProps,
         pagesize = 0;
         needHugepage = false;
         useHugepage = false;
-    } else if (pagesize == 0) {
+    } else if (useHugepage && pagesize == 0) {
         if (qemuBuildMemoryGetDefaultPagesize(cfg, &pagesize) < 0)
             goto cleanup;
     }