]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-mail: test-* - Add missing test_assert
authorAki Tuomi <aki.tuomi@open-xchange.com>
Mon, 9 Nov 2020 07:29:26 +0000 (09:29 +0200)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Wed, 11 Nov 2020 11:53:36 +0000 (11:53 +0000)
Need to ensure stream did not fail during parsing.

src/lib-mail/test-message-decoder.c
src/lib-mail/test-message-parser.c
src/lib-mail/test-message-part.c

index 3007283cad06f684ce0c006e25b96edcc06a52b6..f1b090167365800d45ea8eec40b5df8fdc112907 100644 (file)
@@ -141,6 +141,7 @@ static void test_message_decoder_multipart(void)
 
        message_decoder_deinit(&decoder);
        message_parser_deinit(&parser, &parts);
+       test_assert(istream->stream_errno == 0);
        i_stream_unref(&istream);
        test_end();
 }
index 32226febc7b9ba3ce6f20ae573abecae36b07bc5..43d6ed66d340df010c1ee0870d789aaeef0b00b6 100644 (file)
@@ -57,6 +57,7 @@ static int message_parse_stream(pool_t pool, struct istream *input,
                        message_part_data_parse_from_header(pool, block.part,
                                                            block.hdr);
        message_parser_deinit(&parser, parts_r);
+       test_assert(input->stream_errno == 0);
        return ret;
 }
 
@@ -118,6 +119,7 @@ static void test_message_parser_small_blocks(void)
 
        test_assert(ret < 0);
        message_parser_deinit(&parser, &parts);
+       test_assert(input->stream_errno == 0);
        test_assert(strcmp(test_msg, str_c(output)) == 0);
 
        /* parsing in small blocks */
@@ -135,6 +137,7 @@ static void test_message_parser_small_blocks(void)
                            (ret < 0 && i > TEST_MSG_LEN*2));
        }
        message_parser_deinit(&parser, &parts2);
+       test_assert(input->stream_errno == 0);
        test_assert(message_part_is_equal(parts, parts2));
 
        /* parsing in small blocks from preparsed parts */
@@ -747,6 +750,7 @@ static void test_message_parser_no_eoh(void)
                    block.hdr == NULL && block.size == 0);
        test_assert(message_parser_parse_next_block(parser, &block) < 0);
        message_parser_deinit(&parser, &parts);
+       test_assert(input->stream_errno == 0);
 
        test_parsed_parts(input, parts);
        i_stream_unref(&input);
index 4a51a39f99fc357eb3457580f0c1d8a0a21c7ef8..49cfd65a21b2eee2f69869ac0ce79e3aa0d11474 100644 (file)
@@ -86,6 +86,7 @@ static void test_message_part_idx(void)
        }
        test_assert(ret < 0);
        message_parser_deinit(&parser, &parts);
+       test_assert(input->stream_errno == 0);
 
        part = message_part_by_idx(parts, 0);
        test_assert(part == parts);