Bug #1620: http_reply_access denied replies casuses assertion failure

We will generate a new (error) reply, so existing reply can be discarded.

diff --git a/src/client_side_reply.cc b/src/client_side_reply.cc
index 3b2bdaab3419572603e5fb5bda64da07929c88e0..be8673133fc92e09e15c0e93dd006a4ec1c77410 100644 (file)
--- a/src/client_side_reply.cc
+++ b/src/client_side_reply.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: client_side_reply.cc,v 1.109 2006/06/07 22:39:34 hno Exp $
+ * $Id: client_side_reply.cc,v 1.110 2006/07/02 10:02:04 serassio Exp $
  *
  * DEBUG: section 88    Client-side Reply Routines
  * AUTHOR: Robert Collins (Originally Duane Wessels in client_side.c)
@@ -1756,8 +1756,8 @@ clientReplyContext::processReplyAccess ()
                              http->getConn().getRaw() != NULL ? &http->getConn()->peer.sin_addr : &no_addr,
                              http->request);
         removeClientStoreReference(&sc, http);
-        startError(err);
         HTTPMSGUNLOCK(reply);
+        startError(err);
         return;
     }
 
@@ -1802,10 +1802,10 @@ clientReplyContext::processReplyAccessResult(bool accessAllowed)
 
         removeClientStoreReference(&sc, http);
 
-        startError(err);
-
         HTTPMSGUNLOCK(reply);
 
+        startError(err);
+
         http->logType = LOG_TCP_DENIED_REPLY;
 
         return;