btrfs: fix a race between renames and directory logging

We have a race between a rename and directory inode logging that if it
happens and we crash/power fail before the rename completes, the next time
the filesystem is mounted, the log replay code will end up deleting the
file that was being renamed.

This is best explained following a step by step analysis of an interleaving
of steps that lead into this situation.

Consider the initial conditions:

1) We are at transaction N;

2) We have directories A and B created in a past transaction (< N);

3) We have inode X corresponding to a file that has 2 hardlinks, one in
   directory A and the other in directory B, so we'll name them as
   "A/foo_link1" and "B/foo_link2". Both hard links were persisted in a
   past transaction (< N);

4) We have inode Y corresponding to a file that as a single hard link and
   is located in directory A, we'll name it as "A/bar". This file was also
   persisted in a past transaction (< N).

The steps leading to a file loss are the following and for all of them we
are under transaction N:

 1) Link "A/foo_link1" is removed, so inode's X last_unlink_trans field
    is updated to N, through btrfs_unlink() -> btrfs_record_unlink_dir();

 2) Task A starts a rename for inode Y, with the goal of renaming from
    "A/bar" to "A/baz", so we enter btrfs_rename();

 3) Task A inserts the new BTRFS_INODE_REF_KEY for inode Y by calling
    btrfs_insert_inode_ref();

 4) Because the rename happens in the same directory, we don't set the
    last_unlink_trans field of directoty A's inode to the current
    transaction id, that is, we don't cal btrfs_record_unlink_dir();

 5) Task A then removes the entries from directory A (BTRFS_DIR_ITEM_KEY
    and BTRFS_DIR_INDEX_KEY items) when calling __btrfs_unlink_inode()
    (actually the dir index item is added as a delayed item, but the
    effect is the same);

 6) Now before task A adds the new entry "A/baz" to directory A by
    calling btrfs_add_link(), another task, task B is logging inode X;

 7) Task B starts a fsync of inode X and after logging inode X, at
    btrfs_log_inode_parent() it calls btrfs_log_all_parents(), since
    inode X has a last_unlink_trans value of N, set at in step 1;

 8) At btrfs_log_all_parents() we search for all parent directories of
    inode X using the commit root, so we find directories A and B and log
    them. Bu when logging direct A, we don't have a dir index item for
    inode Y anymore, neither the old name "A/bar" nor for the new name
    "A/baz" since the rename has deleted the old name but has not yet
    inserted the new name - task A hasn't called yet btrfs_add_link() to
    do that.

    Note that logging directory A doesn't fallback to a transaction
    commit because its last_unlink_trans has a lower value than the
    current transaction's id (see step 4);

 9) Task B finishes logging directories A and B and gets back to
    btrfs_sync_file() where it calls btrfs_sync_log() to persist the log
    tree;

10) Task B successfully persisted the log tree, btrfs_sync_log() completed
    with success, and a power failure happened.

    We have a log tree without any directory entry for inode Y, so the
    log replay code deletes the entry for inode Y, name "A/bar", from the
    subvolume tree since it doesn't exist in the log tree and the log
    tree is authorative for its index (we logged a BTRFS_DIR_LOG_INDEX_KEY
    item that covers the index range for the dentry that corresponds to
    "A/bar").

    Since there's no other hard link for inode Y and the log replay code
    deletes the name "A/bar", the file is lost.

The issue wouldn't happen if task B synced the log only after task A
called btrfs_log_new_name(), which would update the log with the new name
for inode Y ("A/bar").

Fix this by pinning the log root during renames before removing the old
directory entry, and unpinning after btrfs_log_new_name() is called.

Fixes: 259c4b96d78d ("btrfs: stop doing unnecessary log updates during a rename")
CC: stable@vger.kernel.org # 5.18+
Reviewed-by: Boris Burkov <boris@bur.io>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index a62f92ab5977bc4173ba3978fecb96654434b0e3..26d6ed170a1945b83e311d76b233533ea4ad2976 100644 (file)
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -8059,6 +8059,7 @@ static int btrfs_rename_exchange(struct inode *old_dir,
        int ret;
        int ret2;
        bool need_abort = false;
+       bool logs_pinned = false;
        struct fscrypt_name old_fname, new_fname;
        struct fscrypt_str *old_name, *new_name;
 
@@ -8182,6 +8183,31 @@ static int btrfs_rename_exchange(struct inode *old_dir,
        inode_inc_iversion(new_inode);
        simple_rename_timestamp(old_dir, old_dentry, new_dir, new_dentry);
 
+       if (old_ino != BTRFS_FIRST_FREE_OBJECTID &&
+           new_ino != BTRFS_FIRST_FREE_OBJECTID) {
+               /*
+                * If we are renaming in the same directory (and it's not for
+                * root entries) pin the log early to prevent any concurrent
+                * task from logging the directory after we removed the old
+                * entries and before we add the new entries, otherwise that
+                * task can sync a log without any entry for the inodes we are
+                * renaming and therefore replaying that log, if a power failure
+                * happens after syncing the log, would result in deleting the
+                * inodes.
+                *
+                * If the rename affects two different directories, we want to
+                * make sure the that there's no log commit that contains
+                * updates for only one of the directories but not for the
+                * other.
+                *
+                * If we are renaming an entry for a root, we don't care about
+                * log updates since we called btrfs_set_log_full_commit().
+                */
+               btrfs_pin_log_trans(root);
+               btrfs_pin_log_trans(dest);
+               logs_pinned = true;
+       }
+
        if (old_dentry->d_parent != new_dentry->d_parent) {
                btrfs_record_unlink_dir(trans, BTRFS_I(old_dir),
                                        BTRFS_I(old_inode), true);
@@ -8253,30 +8279,23 @@ static int btrfs_rename_exchange(struct inode *old_dir,
                BTRFS_I(new_inode)->dir_index = new_idx;
 
        /*
-        * Now pin the logs of the roots. We do it to ensure that no other task
-        * can sync the logs while we are in progress with the rename, because
-        * that could result in an inconsistency in case any of the inodes that
-        * are part of this rename operation were logged before.
+        * Do the log updates for all inodes.
+        *
+        * If either entry is for a root we don't need to update the logs since
+        * we've called btrfs_set_log_full_commit() before.
         */
-       if (old_ino != BTRFS_FIRST_FREE_OBJECTID)
-               btrfs_pin_log_trans(root);
-       if (new_ino != BTRFS_FIRST_FREE_OBJECTID)
-               btrfs_pin_log_trans(dest);
-
-       /* Do the log updates for all inodes. */
-       if (old_ino != BTRFS_FIRST_FREE_OBJECTID)
+       if (logs_pinned) {
                btrfs_log_new_name(trans, old_dentry, BTRFS_I(old_dir),
                                   old_rename_ctx.index, new_dentry->d_parent);
-       if (new_ino != BTRFS_FIRST_FREE_OBJECTID)
                btrfs_log_new_name(trans, new_dentry, BTRFS_I(new_dir),
                                   new_rename_ctx.index, old_dentry->d_parent);
+       }
 
-       /* Now unpin the logs. */
-       if (old_ino != BTRFS_FIRST_FREE_OBJECTID)
+out_fail:
+       if (logs_pinned) {
                btrfs_end_log_trans(root);
-       if (new_ino != BTRFS_FIRST_FREE_OBJECTID)
                btrfs_end_log_trans(dest);
-out_fail:
+       }
        ret2 = btrfs_end_transaction(trans);
        ret = ret ? ret : ret2;
 out_notrans:
@@ -8326,6 +8345,7 @@ static int btrfs_rename(struct mnt_idmap *idmap,
        int ret2;
        u64 old_ino = btrfs_ino(BTRFS_I(old_inode));
        struct fscrypt_name old_fname, new_fname;
+       bool logs_pinned = false;
 
        if (btrfs_ino(BTRFS_I(new_dir)) == BTRFS_EMPTY_SUBVOL_DIR_OBJECTID)
                return -EPERM;
@@ -8460,6 +8480,29 @@ static int btrfs_rename(struct mnt_idmap *idmap,
        inode_inc_iversion(old_inode);
        simple_rename_timestamp(old_dir, old_dentry, new_dir, new_dentry);
 
+       if (old_ino != BTRFS_FIRST_FREE_OBJECTID) {
+               /*
+                * If we are renaming in the same directory (and it's not a
+                * root entry) pin the log to prevent any concurrent task from
+                * logging the directory after we removed the old entry and
+                * before we add the new entry, otherwise that task can sync
+                * a log without any entry for the inode we are renaming and
+                * therefore replaying that log, if a power failure happens
+                * after syncing the log, would result in deleting the inode.
+                *
+                * If the rename affects two different directories, we want to
+                * make sure the that there's no log commit that contains
+                * updates for only one of the directories but not for the
+                * other.
+                *
+                * If we are renaming an entry for a root, we don't care about
+                * log updates since we called btrfs_set_log_full_commit().
+                */
+               btrfs_pin_log_trans(root);
+               btrfs_pin_log_trans(dest);
+               logs_pinned = true;
+       }
+
        if (old_dentry->d_parent != new_dentry->d_parent)
                btrfs_record_unlink_dir(trans, BTRFS_I(old_dir),
                                        BTRFS_I(old_inode), true);
@@ -8524,7 +8567,7 @@ static int btrfs_rename(struct mnt_idmap *idmap,
        if (old_inode->i_nlink == 1)
                BTRFS_I(old_inode)->dir_index = index;
 
-       if (old_ino != BTRFS_FIRST_FREE_OBJECTID)
+       if (logs_pinned)
                btrfs_log_new_name(trans, old_dentry, BTRFS_I(old_dir),
                                   rename_ctx.index, new_dentry->d_parent);
 
@@ -8540,6 +8583,10 @@ static int btrfs_rename(struct mnt_idmap *idmap,
                }
        }
 out_fail:
+       if (logs_pinned) {
+               btrfs_end_log_trans(root);
+               btrfs_end_log_trans(dest);
+       }
        ret2 = btrfs_end_transaction(trans);
        ret = ret ? ret : ret2;
 out_notrans: