]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
tree-optimization/112859 - add comment
authorRichard Biener <rguenther@suse.de>
Tue, 28 Jan 2025 14:01:25 +0000 (15:01 +0100)
committerRichard Biener <rguenth@gcc.gnu.org>
Tue, 28 Jan 2025 14:03:05 +0000 (15:03 +0100)
This adds a comment before the workaround, indicating flaky
dependence analysis.

PR tree-optimization/112859
* tree-loop-distribution.cc
(loop_distribution::pg_add_dependence_edges): Add comment.

gcc/tree-loop-distribution.cc

index 9d9d2ae592b3dfa56e0cca44af2e831a011785fb..fc0cd3952d569be989ec31f2b581ffd66d2ddc2f 100644 (file)
@@ -2193,7 +2193,9 @@ loop_distribution::pg_add_dependence_edges (struct graph *rdg, int dir,
                      this_dir = -this_dir;
                    }
                  /* When then dependence distance of the innermost common
-                    loop of the DRs is zero we have a conflict.  */
+                    loop of the DRs is zero we have a conflict.  This is
+                    due to wonky dependence analysis which sometimes
+                    ends up using a zero distance in place of unknown.  */
                  auto l1 = gimple_bb (DR_STMT (dr1))->loop_father;
                  auto l2 = gimple_bb (DR_STMT (dr2))->loop_father;
                  int idx = index_in_loop_nest (find_common_loop (l1, l2)->num,