]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
dt-bindings: PCI: qcom: Allow 'vddpe-3v3-supply' again
authorJohan Hovold <johan+linaro@kernel.org>
Tue, 23 Jul 2024 15:13:28 +0000 (17:13 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 13 Sep 2024 23:59:48 +0000 (18:59 -0500)
Commit 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to
dedicated schema") incorrectly removed 'vddpe-3v3-supply' from the
bindings, which results in DT checker warnings like:

  arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb: pcie@600000: Unevaluated properties are not allowed ('vddpe-3v3-supply' was unexpected)
  from schema $id: http://devicetree.org/schemas/pci/qcom,pcie.yaml#

Note that this property has been part of the Qualcomm PCIe bindings since
2018 and would need to be deprecated rather than simply removed if there is
a desire to replace it with 'vpcie3v3' which is used for some non-Qualcomm
controllers.

Link: https://lore.kernel.org/lkml/Zp_LPixNnh-2Fy5N@hovoldconsulting.com/
Fixes: 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to dedicated schema")
Link: https://lore.kernel.org/r/20240723151328.684-1-johan+linaro@kernel.org
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml
Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml
Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml
Documentation/devicetree/bindings/pci/qcom,pcie.yaml

index 0a39bbfcb28b08c12b130468108bd452c7320ec9..2b6f5a171f20ffd3652c07c08403ea6d99ceedc2 100644 (file)
@@ -78,6 +78,9 @@ properties:
     description: GPIO controlled connection to WAKE# signal
     maxItems: 1
 
+  vddpe-3v3-supply:
+    description: PCIe endpoint power supply
+
 required:
   - reg
   - reg-names
index 5cf1f916530139f569780a88be1bf7888c2d0c40..76cb9fbfd476fb0412217c68bd8db44a51c7d236 100644 (file)
@@ -74,9 +74,6 @@ properties:
     items:
       - const: pci
 
-  vddpe-3v3-supply:
-    description: PCIe endpoint power supply
-
 allOf:
   - $ref: qcom,pcie-common.yaml#
 
index 25c9f13ae97723de5756bda2b711dd2e437ce3aa..15ba2385eb73c4e69d6de7dc09cf639bc800f7f2 100644 (file)
@@ -58,9 +58,6 @@ properties:
     items:
       - const: pci
 
-  vddpe-3v3-supply:
-    description: A phandle to the PCIe endpoint power supply
-
 required:
   - interconnects
   - interconnect-names
index f867746b1ae594a4f6b3cea171f245be866bdf53..ffabbac57fc1670024526a68193e67f4ec9f50ab 100644 (file)
@@ -91,6 +91,9 @@ properties:
   vdda_refclk-supply:
     description: A phandle to the core analog power supply for IC which generates reference clock
 
+  vddpe-3v3-supply:
+    description: A phandle to the PCIe endpoint power supply
+
   phys:
     maxItems: 1