]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
select: Convert to scoped user access
authorThomas Gleixner <tglx@linutronix.de>
Mon, 27 Oct 2025 08:44:04 +0000 (09:44 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 4 Nov 2025 07:28:34 +0000 (08:28 +0100)
Replace the open coded implementation with the scoped user access guard.

No functional change intended.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://patch.msgid.link/20251027083745.862419776@linutronix.de
fs/select.c

index 082cf60c7e2357dfd419c2128e38da95e3ef2ef3..65019b8ba3f74b6741f8af01a1221d912325e955 100644 (file)
@@ -776,17 +776,13 @@ static inline int get_sigset_argpack(struct sigset_argpack *to,
 {
        // the path is hot enough for overhead of copy_from_user() to matter
        if (from) {
-               if (can_do_masked_user_access())
-                       from = masked_user_access_begin(from);
-               else if (!user_read_access_begin(from, sizeof(*from)))
-                       return -EFAULT;
-               unsafe_get_user(to->p, &from->p, Efault);
-               unsafe_get_user(to->size, &from->size, Efault);
-               user_read_access_end();
+               scoped_user_read_access(from, Efault) {
+                       unsafe_get_user(to->p, &from->p, Efault);
+                       unsafe_get_user(to->size, &from->size, Efault);
+               }
        }
        return 0;
 Efault:
-       user_read_access_end();
        return -EFAULT;
 }