]> git.ipfire.org Git - thirdparty/nftables.git/commitdiff
tests: regression: fix "Listing is broken" instead of output mismatch
authorPablo Neira Ayuso <pablo@netfilter.org>
Sun, 30 Nov 2014 20:39:24 +0000 (21:39 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 1 Dec 2014 16:28:25 +0000 (17:28 +0100)
If the output string doesn't match the input, indicate that the output
mismatches instead of the misleading "Listing is broken".

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
tests/regression/nft-test.py

index e1aec893023b20c96cbc0b38b86b709adf7e24ab..9998ab3583fa51541b8fc77805ef9ec7cb12a687 100755 (executable)
@@ -505,15 +505,12 @@ def rule_add(rule, table_list, chain_list, filename, lineno,
                                                         rule_output, cmd)
                                 if not force_all_family_option:
                                     return [ret, warning, error, unit_tests]
-                            if rule[0].find(rule_output.split(" ")[0]) > -1:
-                                warning += 1
-                                print_differences_warning(filename, lineno,
-                                                          rule[0], rule_output,
-                                                          cmd)
-                            else:
-                                error += 1
-                                print_differences_error(filename, lineno,
-                                                        rule_output, cmd)
+
+                            warning += 1
+                            print_differences_warning(filename, lineno,
+                                                      rule[0], rule_output,
+                                                      cmd)
+
                             if not force_all_family_option:
                                 return [ret, warning, error, unit_tests]