]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
IB/hfi1: Adjust fd->entry_to_rb allocation type
authorKees Cook <kees@kernel.org>
Sat, 26 Apr 2025 06:12:48 +0000 (23:12 -0700)
committerLeon Romanovsky <leon@kernel.org>
Sun, 27 Apr 2025 11:51:20 +0000 (07:51 -0400)
In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "struct tid_rb_node **", but the return type will be
"struct rb_node **". These are the same allocation size (pointer size),
but the types do not match. Adjust the allocation type to match the
assignment.

Signed-off-by: Kees Cook <kees@kernel.org>
Link: https://patch.msgid.link/20250426061247.work.261-kees@kernel.org
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/hfi1/user_exp_rcv.c

index cf2d29098406f85da85019333b2e171ef9add372..62b4f16dab27d85c7a3d55c08601f1d4a4b7bba7 100644 (file)
@@ -53,7 +53,7 @@ int hfi1_user_exp_rcv_init(struct hfi1_filedata *fd,
        int ret = 0;
 
        fd->entry_to_rb = kcalloc(uctxt->expected_count,
-                                 sizeof(struct rb_node *),
+                                 sizeof(*fd->entry_to_rb),
                                  GFP_KERNEL);
        if (!fd->entry_to_rb)
                return -ENOMEM;