]> git.ipfire.org Git - thirdparty/google/fonts.git/commitdiff
make family_name optional
authorMarc Foley <m.foley.88@gmail.com>
Fri, 1 Jul 2022 11:43:09 +0000 (12:43 +0100)
committerMarc Foley <m.foley.88@gmail.com>
Fri, 1 Jul 2022 11:43:09 +0000 (12:43 +0100)
Lib/axisregistry/__init__.py
tests/test_names.py

index 3c4c3f0b9207574761e54c0b3d15a809931db30e..f90a6b1064851947b5ae8c728422d0a27f220cd6 100644 (file)
@@ -275,8 +275,10 @@ def build_vf_name_table(ttFont, family_name, siblings=[]):
     build_variations_ps_name(ttFont, family_name)
 
 
-def build_variations_ps_name(ttFont, family_name):
+def build_variations_ps_name(ttFont, family_name=None):
     assert is_variable(ttFont), "Not a VF!"
+    if not family_name:
+        family_name = ttFont["name"].getBestFamilyName()
     font_styles = axis_registry.fallbacks_in_name_table(ttFont)
     if font_styles:
         vf_ps = family_name.replace(" ", "") + "".join(
index 25cf933ceb37e056a89100821aec7860a83e6d3a..1a907967db493f718d70722b7d4568a603f99c7b 100644 (file)
@@ -522,7 +522,6 @@ def test_fvar_instance_collisions(fp, sibling_fps, result):
 )
 def test_build_variations_ps_name(fp, result):
     ttFont = TTFont(fp)
-    family_name = ttFont["name"].getBestFamilyName()
-    build_variations_ps_name(ttFont, family_name)
+    build_variations_ps_name(ttFont)
     variation_ps_name = ttFont["name"].getName(25, 3, 1, 0x409).toUnicode()
     assert variation_ps_name == result