]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
FILS: Check req_ies for NULL pointer in hostapd_notif_assoc()
authorPeng Xu <pxu@qti.qualcomm.com>
Thu, 7 Sep 2017 18:21:11 +0000 (11:21 -0700)
committerJouni Malinen <j@w1.fi>
Tue, 19 Sep 2017 12:28:58 +0000 (15:28 +0300)
Add checking for NULL req_ies when FILS processing a driver ASSOC event
in hostapd_notif_assoc(). This was already done in number of old code
paths, but the newer FILS path did not handle this. Though, it is
unlikely that this code path would be reachable in practice since this
is all within sta->auth_alg == WLAN_AUTH_FILS_* check.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
src/ap/drv_callbacks.c

index cce625bf0dfd3762f2c5cccc8911367aeaf6cba0..8841e843ac17b8baa613edaa046021a28aea8a34 100644 (file)
@@ -451,6 +451,9 @@ skip_wpa_check:
            sta->auth_alg == WLAN_AUTH_FILS_PK) {
                int delay_assoc = 0;
 
+               if (!req_ies)
+                       return WLAN_STATUS_UNSPECIFIED_FAILURE;
+
                if (!wpa_fils_validate_fils_session(sta->wpa_sm, req_ies,
                                                    req_ies_len,
                                                    sta->fils_session)) {