Including the phrase EXCLUDE NO OTHERS in the frame-spec of a window function

(which is the default setting for EXCLUDE) silently disables the xInverse
optimization.  This is a feature, but we will keep it undocumented for now
in case we later decide it is a bad idea.

FossilOrigin-Name: 10aedce3dd2c0c9f0ee9e0aefd0b4d2c2eb17c4ca72003c4db9768ea5cdafcf4

diff --git a/manifest b/manifest
index 5333df8c8ac919b7ae267baa2b29b4ce60ac6679..87b325c14c6e13de0bdf76dfffe35c58adbfec41 100644 (file)
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Put\sthe\slist\sof\skeywords\sin\smkkeywordhash.c\sinto\salphabetical\sorder.
-D 2019-04-02T13:10:50.080
+C Including\sthe\sphrase\sEXCLUDE\sNO\sOTHERS\sin\sthe\sframe-spec\sof\sa\swindow\sfunction\n(which\sis\sthe\sdefault\ssetting\sfor\sEXCLUDE)\ssilently\sdisables\sthe\sxInverse\noptimization.\s\sThis\sis\sa\sfeature,\sbut\swe\swill\skeep\sit\sundocumented\sfor\snow\nin\scase\swe\slater\sdecide\sit\sis\sa\sbad\sidea.
+D 2019-04-02T17:45:01.994
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -506,7 +506,7 @@ F src/os_win.c 85d9e532d0444ab6c16d7431490c2e279e282aa0917b0e988996b1ae0de5c5a0
 F src/os_win.h 7b073010f1451abe501be30d12f6bc599824944a
 F src/pager.c 422fd8cfa59fb9173eff36a95878904a0eeb0dcc62ba49350acc8b1e51c4dc7b
 F src/pager.h 217921e81eb5fe455caa5cda96061959706bcdd29ddb57166198645ef7822ac3
-F src/parse.y a020386af1739371b2eafba077497aacf2a840d1a178508dc6f8c19448e42054
+F src/parse.y db16b24caee36f68746fd4748cab3c53238a8a4a78587659733e41c84d7be36d
 F src/pcache.c 696a01f1a6370c1b50a09c15972bc3bee3333f8fcd1f2da8e9a76b1b062c59ee
 F src/pcache.h 4f87acd914cef5016fae3030343540d75f5b85a1877eed1a2a19b9f284248586
 F src/pcache1.c a72804486dfa8e4b6bc30d666c97ecf1155f91a4351fc6e48ea4097e4eb304fb
@@ -1815,7 +1815,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P f7ba2daf91c96ba16958188d6084a0ff129310d348932de493d326f1d24679cd
-R fb5baea31c37dc7a14f14dc93cb58885
+P ac98b23b34632fbc654a34a8b3d842ce65603e4c04d89c589b46f4d48a61152d
+R ccc26cc09417891dfc0ff61e732d7e8b
 U drh
-Z 5e2fb03c081becc1703e189975bd7451
+Z a38f1dddda472c0bcfd7c92782bb8c85

diff --git a/manifest.uuid b/manifest.uuid
index 798d0f570b4c710336f429e83c2a4c24051244b5..fe740400212a4491e604e93db50f951f89cce47c 100644 (file)
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-ac98b23b34632fbc654a34a8b3d842ce65603e4c04d89c589b46f4d48a61152d
\ No newline at end of file
+10aedce3dd2c0c9f0ee9e0aefd0b4d2c2eb17c4ca72003c4db9768ea5cdafcf4
\ No newline at end of file

diff --git a/src/parse.y b/src/parse.y
index e0d9a16c2b1270b4282c282edd2b061bd31c2617..61e4acb68478964c19d370d38016d573a666ee74 100644 (file)
--- a/src/parse.y
+++ b/src/parse.y
@@ -1717,7 +1717,7 @@ frame_exclude_opt(A) ::= . { A = 0; }
 frame_exclude_opt(A) ::= EXCLUDE frame_exclude(X). { A = X; }
 
 %type frame_exclude {u8}
-frame_exclude(A) ::= NO OTHERS.   { A = 0; }
+frame_exclude(A) ::= NO OTHERS.   { A = TK_NO; }
 frame_exclude(A) ::= CURRENT ROW. { A = TK_CURRENT; }
 frame_exclude(A) ::= GROUP.       { A = TK_GROUP; }
 frame_exclude(A) ::= TIES.        { A = TK_TIES; }