]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: phy: micrel: simplify return in ksz9477_phy_errata()
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Fri, 17 Oct 2025 19:35:20 +0000 (12:35 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 20 Oct 2025 23:43:54 +0000 (16:43 -0700)
ksz9477_phy_errata function currently assigns the return value of
genphy_restart_aneg() to a variable and then immediately returns it

    err = genphy_restart_aneg(phydev);
    if (err)
        return err;

    return err;

This can be simplified by directly returning the function call
result, as the intermediate variable and conditional are redundant.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20251017193525.1457064-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/micrel.c

index 79ce3eb6752b6d8609b2f7bcc670f7d7b65be452..65994d97c403c83e18821c5dac73b5e3300052f3 100644 (file)
@@ -2095,11 +2095,7 @@ static int ksz9477_phy_errata(struct phy_device *phydev)
                        return err;
        }
 
-       err = genphy_restart_aneg(phydev);
-       if (err)
-               return err;
-
-       return err;
+       return genphy_restart_aneg(phydev);
 }
 
 static int ksz9477_config_init(struct phy_device *phydev)