orangefs: Remove unused type in macro fill_default_sys_attrs

Remove the unused type parameter from the macro definition and all its
callers, making the interface consistent with its actual usage.

Fixes: 69a23de2f3de ("orangefs: clean up fill_default_sys_attrs")
Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>

diff --git a/fs/orangefs/namei.c b/fs/orangefs/namei.c
index 82395fe2b9562a7ec2d60930f07e56f0837383ba..bec5475de094dada6bb29eaf8520a875880f3bab 100644 (file)
--- a/fs/orangefs/namei.c
+++ b/fs/orangefs/namei.c
@@ -38,8 +38,7 @@ static int orangefs_create(struct mnt_idmap *idmap,
 
        new_op->upcall.req.create.parent_refn = parent->refn;
 
-       fill_default_sys_attrs(new_op->upcall.req.create.attributes,
-                              ORANGEFS_TYPE_METAFILE, mode);
+       fill_default_sys_attrs(new_op->upcall.req.create.attributes, mode);
 
        strscpy(new_op->upcall.req.create.d_name, dentry->d_name.name);
 
@@ -240,9 +239,7 @@ static int orangefs_symlink(struct mnt_idmap *idmap,
 
        new_op->upcall.req.sym.parent_refn = parent->refn;
 
-       fill_default_sys_attrs(new_op->upcall.req.sym.attributes,
-                              ORANGEFS_TYPE_SYMLINK,
-                              mode);
+       fill_default_sys_attrs(new_op->upcall.req.sym.attributes, mode);
 
        strscpy(new_op->upcall.req.sym.entry_name, dentry->d_name.name);
        strscpy(new_op->upcall.req.sym.target, symname);
@@ -316,8 +313,7 @@ static struct dentry *orangefs_mkdir(struct mnt_idmap *idmap, struct inode *dir,
 
        new_op->upcall.req.mkdir.parent_refn = parent->refn;
 
-       fill_default_sys_attrs(new_op->upcall.req.mkdir.attributes,
-                             ORANGEFS_TYPE_DIRECTORY, mode);
+       fill_default_sys_attrs(new_op->upcall.req.mkdir.attributes, mode);
 
        strscpy(new_op->upcall.req.mkdir.d_name, dentry->d_name.name);
 

diff --git a/fs/orangefs/orangefs-kernel.h b/fs/orangefs/orangefs-kernel.h
index 3e153c2f6b828dc3fda3b9f3e94ca887207c67fe..29c6da43e39663780b812abff698ec14c2c13f0f 100644 (file)
--- a/fs/orangefs/orangefs-kernel.h
+++ b/fs/orangefs/orangefs-kernel.h
@@ -462,7 +462,7 @@ int service_operation(struct orangefs_kernel_op_s *op,
        ((ORANGEFS_SB(inode->i_sb)->flags & ORANGEFS_OPT_INTR) ? \
                ORANGEFS_OP_INTERRUPTIBLE : 0)
 
-#define fill_default_sys_attrs(sys_attr, type, mode)                   \
+#define fill_default_sys_attrs(sys_attr, mode)                 \
 do {                                                                   \
        sys_attr.owner = from_kuid(&init_user_ns, current_fsuid()); \
        sys_attr.group = from_kgid(&init_user_ns, current_fsgid()); \