]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
Fix uninitialized memory problem in group_sids_to_info3 (fixes bug #8455).
authorWilco Baan Hofman <wilco@baanhofman.nl>
Mon, 17 Oct 2011 19:24:41 +0000 (21:24 +0200)
committerKarolin Seeger <kseeger@samba.org>
Tue, 18 Oct 2011 18:48:41 +0000 (20:48 +0200)
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Oct 17 23:32:58 CEST 2011 on sn-devel-104
(cherry picked from commit c52b571506874987ba626c25e9692fbe2251b7e2)
(cherry picked from commit 31c00e9314e735505590f98565dcb5aa58453d0e)

source3/auth/server_info.c

index c6d68c24d7dc4831e0947d84b6c6ee9954968cf8..dc5b15f78bacffc4b81e81d837811289e110e594 100644 (file)
@@ -279,8 +279,8 @@ static NTSTATUS group_sids_to_info3(struct netr_SamInfo3 *info3,
                        if (info3->base.primary_gid == rid) continue;
 
                        /* store domain group rid */
-                       groups->rids[i].rid = rid;
-                       groups->rids[i].attributes = attributes;
+                       groups->rids[groups->count].rid = rid;
+                       groups->rids[groups->count].attributes = attributes;
                        groups->count++;
                        continue;
                }