]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: stmmac: print stmmac_init_dma_engine() errors using netdev_err()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thu, 20 Feb 2025 12:47:49 +0000 (12:47 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 22 Feb 2025 00:29:05 +0000 (16:29 -0800)
stmmac_init_dma_engine() uses dev_err() which leads to errors being
reported as e.g:

dwc-eth-dwmac 2490000.ethernet: Failed to reset the dma
dwc-eth-dwmac 2490000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed

stmmac_init_dma_engine() is only called from stmmac_hw_setup() which
itself uses netdev_err(), and we will have a net_device setup. So,
change the dev_err() to netdev_err() to give consistent error
messages.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1tl5y1-004UgG-8X@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

index edf4b1d651a6ec2a97d0ea6ebc8f42213a3edf69..424fa2fe31c6c1fc0f2a527dfa6c42aa5595e793 100644 (file)
@@ -3047,7 +3047,7 @@ static int stmmac_init_dma_engine(struct stmmac_priv *priv)
        int ret = 0;
 
        if (!priv->plat->dma_cfg || !priv->plat->dma_cfg->pbl) {
-               dev_err(priv->device, "Invalid DMA configuration\n");
+               netdev_err(priv->dev, "Invalid DMA configuration\n");
                return -EINVAL;
        }
 
@@ -3056,7 +3056,7 @@ static int stmmac_init_dma_engine(struct stmmac_priv *priv)
 
        ret = stmmac_reset(priv, priv->ioaddr);
        if (ret) {
-               dev_err(priv->device, "Failed to reset the dma\n");
+               netdev_err(priv->dev, "Failed to reset the dma\n");
                return ret;
        }