]> git.ipfire.org Git - thirdparty/git.git/commitdiff
git-gui: drop no-op GITGUI_SCRIPT replacement
authorPatrick Steinhardt <ps@pks.im>
Tue, 11 Mar 2025 10:07:08 +0000 (11:07 +0100)
committerPatrick Steinhardt <ps@pks.im>
Tue, 13 May 2025 06:27:11 +0000 (08:27 +0200)
The value of the GITGUI_SCRIPT variable is only used in a single place
as part of an sed(1) script that massages the "git-gui.sh" script.
Interestingly, this specific replacement does seem to be a no-op: we
replace "^ argv0=$$0" with " argv=$(GITGUI_SCRIPT)", which has a value
of "$$0". The result would thus be completely unchanged.

Drop the replacement and its variable.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Makefile

index ea22b3af5d8ea22772d00e37f2e725e1e19ba732..1cbb16a92196a132bbe12fe1d91a15184852be63 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -134,7 +134,6 @@ libdir_SQ  = $(subst ','\'',$(gg_libdir))
 libdir_SED = $(subst ','\'',$(subst \,\\,$(gg_libdir_sed_in)))
 exedir     = $(dir $(gitexecdir))share/git-gui/lib
 
-GITGUI_SCRIPT   := $$0
 GITGUI_RELATIVE :=
 GITGUI_MACOSXAPP :=
 
@@ -206,7 +205,6 @@ $(GITGUI_MAIN): git-gui.sh GIT-VERSION-FILE GIT-GUI-BUILD-OPTIONS
        $(QUIET_GEN)rm -f $@ $@+ && \
        sed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \
                -e 's|@@SHELL_PATH@@|$(SHELL_PATH_SQ)|' \
-               -e '1,30s|^ argv0=$$0| argv0=$(GITGUI_SCRIPT)|' \
                -e '1,30s|^ exec wish | exec '\''$(TCLTK_PATH_SED)'\'' |' \
                -e 's/@@GITGUI_VERSION@@/$(GITGUI_VERSION)/g' \
                -e 's|@@GITGUI_RELATIVE@@|$(GITGUI_RELATIVE)|' \