media: ti: j721e-csi2rx: Fix source subdev link creation

We don't use OF ports and remote-endpoints to connect the CSI2RX bridge
and this device in the device tree, thus it is wrong to use
v4l2_create_fwnode_links_to_pad() to create the media graph link between
the two.

It works out on accident, as neither the source nor the sink implement
the .get_fwnode_pad() callback, and the framework helper falls back on
using the first source and sink pads to create the link between them.

Instead, manually create the media link from the first source pad of the
bridge to the first sink pad of the J721E CSI2RX.

Fixes: b4a3d877dc92 ("media: ti: Add CSI2RX support for J721E")
Cc: stable@vger.kernel.org
Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
Tested-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com> (on SK-AM68)
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
index cad873b48c20885dc6c2333c92ea0bb1bf8a0268..094cf40ee492b1af2946da29e6c89ead1ca602b0 100644 (file)
--- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
+++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
@@ -53,6 +53,8 @@
 #define DRAIN_TIMEOUT_MS               50
 #define DRAIN_BUFFER_SIZE              SZ_32K
 
+#define CSI2RX_BRIDGE_SOURCE_PAD       1
+
 struct ti_csi2rx_fmt {
        u32                             fourcc; /* Four character code. */
        u32                             code;   /* Mbus code. */
@@ -427,8 +429,9 @@ static int csi_async_notifier_complete(struct v4l2_async_notifier *notifier)
        if (ret)
                return ret;
 
-       ret = v4l2_create_fwnode_links_to_pad(csi->source, &csi->pad,
-                                             MEDIA_LNK_FL_IMMUTABLE | MEDIA_LNK_FL_ENABLED);
+       ret = media_create_pad_link(&csi->source->entity, CSI2RX_BRIDGE_SOURCE_PAD,
+                                   &vdev->entity, csi->pad.index,
+                                   MEDIA_LNK_FL_IMMUTABLE | MEDIA_LNK_FL_ENABLED);
 
        if (ret) {
                video_unregister_device(vdev);