]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net/mlx5: Remove pointless devlink_rate checks
authorJiri Pirko <jiri@nvidia.com>
Wed, 31 May 2023 11:25:15 +0000 (13:25 +0200)
committerSaeed Mahameed <saeedm@nvidia.com>
Thu, 27 Jul 2023 18:37:30 +0000 (11:37 -0700)
It is guaranteed that the devlink rate leaf is created during init paths.
No need to check during cleanup. Remove the checks.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Shay Drory <shayd@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/esw/devlink_port.c

index af779c700278ed4f4c5c4c203c231de85ffbe731..433541ac36a77dc2d9921514e4441c4fbf784d02 100644 (file)
@@ -132,10 +132,8 @@ void mlx5_esw_offloads_devlink_port_unregister(struct mlx5_eswitch *esw, u16 vpo
        if (IS_ERR(vport))
                return;
 
-       if (vport->dl_port->devlink_rate) {
-               mlx5_esw_qos_vport_update_group(esw, vport, NULL, NULL);
-               devl_rate_leaf_destroy(vport->dl_port);
-       }
+       mlx5_esw_qos_vport_update_group(esw, vport, NULL, NULL);
+       devl_rate_leaf_destroy(vport->dl_port);
 
        devl_port_unregister(vport->dl_port);
        mlx5_esw_dl_port_free(vport->dl_port);
@@ -211,10 +209,8 @@ void mlx5_esw_devlink_sf_port_unregister(struct mlx5_eswitch *esw, u16 vport_num
        if (IS_ERR(vport))
                return;
 
-       if (vport->dl_port->devlink_rate) {
-               mlx5_esw_qos_vport_update_group(esw, vport, NULL, NULL);
-               devl_rate_leaf_destroy(vport->dl_port);
-       }
+       mlx5_esw_qos_vport_update_group(esw, vport, NULL, NULL);
+       devl_rate_leaf_destroy(vport->dl_port);
 
        devl_port_unregister(vport->dl_port);
        vport->dl_port = NULL;