]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: dac: ad5791: fix storage
authorDavid Lechner <dlechner@baylibre.com>
Wed, 22 Jan 2025 23:16:59 +0000 (17:16 -0600)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 8 Feb 2025 15:10:15 +0000 (15:10 +0000)
IIO uses "natural" alignment so storagebits should always be a power of
2. Change storagebits to 32 since that is the natural size to store 24
bits of data.

The ad5791 driver currently doesn't use this field anywhere and doesn't
support buffered writes, so this does not change anything. We just don't
want anyone to think that it is OK to have storagebits = 24 in other
drivers.

Signed-off-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20250122-iio-dac-ad5791-fix-storagebits-v1-1-53746e0f25cd@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ad5791.c

index 57374f78f6b885e1d4f2fb452ac0563b85fc222e..034228a7c059f136cdecfb4683228d0be4c37477 100644 (file)
@@ -294,7 +294,7 @@ static const struct ad5791_chip_info _name##_chip_info = {          \
                        .scan_type = {                                  \
                                .sign = 'u',                            \
                                .realbits = (bits),                     \
-                               .storagebits = 24,                      \
+                               .storagebits = 32,                      \
                                .shift = (_shift),                      \
                        },                                              \
                        .ext_info = ad5791_ext_info,                    \