]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
spi: spi-cadence: Fix missing spi_controller_is_target() check
authorJinjie Ruan <ruanjinjie@huawei.com>
Mon, 23 Sep 2024 04:00:15 +0000 (12:00 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 30 Sep 2024 20:55:00 +0000 (21:55 +0100)
The spi_controller_is_target() check is missing for pm_runtime_disable()
in cdns_spi_remove(), add it.

Fixes: b1b90514eaa3 ("spi: spi-cadence: Add support for Slave mode")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://patch.msgid.link/20240923040015.3009329-4-ruanjinjie@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence.c

index 087e748d9cc9588c9c9910924113dcca6a2c4f56..3c87d2bf786a9e04a8e118cc9c5c847a176cd717 100644 (file)
@@ -701,8 +701,10 @@ static void cdns_spi_remove(struct platform_device *pdev)
 
        cdns_spi_write(xspi, CDNS_SPI_ER, CDNS_SPI_ER_DISABLE);
 
-       pm_runtime_disable(&pdev->dev);
-       pm_runtime_set_suspended(&pdev->dev);
+       if (!spi_controller_is_target(ctlr)) {
+               pm_runtime_disable(&pdev->dev);
+               pm_runtime_set_suspended(&pdev->dev);
+       }
 
        spi_unregister_controller(ctlr);
 }