]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.19-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Dec 2018 05:54:30 +0000 (06:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Dec 2018 05:54:30 +0000 (06:54 +0100)
added patches:
test_hexdump-use-memcpy-instead-of-strncpy.patch

queue-4.19/series
queue-4.19/test_hexdump-use-memcpy-instead-of-strncpy.patch [new file with mode: 0644]

index 9fa52e38e9f9846330a684f590174e625925c1d9..0738ea788d790ca9b87b4b551f6c622c629135cf 100644 (file)
@@ -1 +1,2 @@
 blk-mq-fix-corruption-with-direct-issue.patch
+test_hexdump-use-memcpy-instead-of-strncpy.patch
diff --git a/queue-4.19/test_hexdump-use-memcpy-instead-of-strncpy.patch b/queue-4.19/test_hexdump-use-memcpy-instead-of-strncpy.patch
new file mode 100644 (file)
index 0000000..06bcb2a
--- /dev/null
@@ -0,0 +1,38 @@
+From b1286ed7158e9b62787508066283ab0b8850b518 Mon Sep 17 00:00:00 2001
+From: Linus Torvalds <torvalds@linux-foundation.org>
+Date: Fri, 30 Nov 2018 12:13:15 -0800
+Subject: test_hexdump: use memcpy instead of strncpy
+
+From: Linus Torvalds <torvalds@linux-foundation.org>
+
+commit b1286ed7158e9b62787508066283ab0b8850b518 upstream.
+
+New versions of gcc reasonably warn about the odd pattern of
+
+       strncpy(p, q, strlen(q));
+
+which really doesn't make sense: the strncpy() ends up being just a slow
+and odd way to write memcpy() in this case.
+
+Apparently there was a patch for this floating around earlier, but it
+got lost.
+
+Acked-again-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
+Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ lib/test_hexdump.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/lib/test_hexdump.c
++++ b/lib/test_hexdump.c
+@@ -99,7 +99,7 @@ static void __init test_hexdump_prepare_
+               const char *q = *result++;
+               size_t amount = strlen(q);
+-              strncpy(p, q, amount);
++              memcpy(p, q, amount);
+               p += amount;
+               *p++ = ' ';