CLEANUP: server: remove ambiguous check in srv_update_addr_port()

A leftover check was left by recent patch series about server
addr:svc_port propagation: a check on (msg) being set was performed
in srv_update_addr_port(), but msg is always set, so the check is not
needed and confuses coverity (See GH #2399)

diff --git a/src/server.c b/src/server.c
index 6a082fcb0f8bb5b04c6df7c6a33952bb37969e66..bc838b3b988edb2166bf0b5e4fb18cbb48abf16c 100644 (file)
--- a/src/server.c
+++ b/src/server.c
@@ -4167,8 +4167,7 @@ const char *srv_update_addr_port(struct server *s, const char *addr, const char
         * s->svc_port is only relevant under inet context
        */
        if ((s->addr.ss_family != AF_INET) && (s->addr.ss_family != AF_INET6)) {
-               if (msg)
-                       chunk_printf(msg, "Update for the current server address family is only supported through configuration file.");
+               chunk_printf(msg, "Update for the current server address family is only supported through configuration file.");
                goto out;
        }